Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Room settings] Hide or disable search in the encrypted rooms #5725

Closed
giomfo opened this issue Mar 1, 2022 · 3 comments
Closed

[Room settings] Hide or disable search in the encrypted rooms #5725

giomfo opened this issue Mar 1, 2022 · 3 comments
Labels
A-Room-Settings T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements X-Needs-Product Requires input from the product team Z-WTF WTF issues: High impact, Low Effort

Comments

@giomfo
Copy link
Member

giomfo commented Mar 1, 2022

Your use case

The option "search room" is currently displayed in the room settings even when the e2e encryption is enabled

image

The search in an encrypted room is not supported for the moment. We should better hide/disable this option in encrypted rooms.

FYI Element-Android displays a dialog when the user select this option
image

Have you considered any alternatives?

No response

Additional context

No response
@giomfo giomfo added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Mar 1, 2022
@giomfo giomfo mentioned this issue Mar 1, 2022
Closed
5 tasks
@pixlwave pixlwave added A-Room-Settings X-Needs-Product Requires input from the product team Z-WTF WTF issues: High impact, Low Effort labels Mar 2, 2022
@daniellekirkwood
Copy link
Contributor

element-hq/element-android#4641

@daniellekirkwood
Copy link
Contributor

Have posted the Android issue for context. This issue is in my backlog.

@daniellekirkwood daniellekirkwood removed their assignment Mar 9, 2022
@yostyle yostyle mentioned this issue May 2, 2022
Merged
@gileluard
Copy link
Contributor

Fixed by #6098

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Room-Settings T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements X-Needs-Product Requires input from the product team Z-WTF WTF issues: High impact, Low Effort
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pixlwave @giomfo @gileluard @daniellekirkwood