Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Room header is showing "Add people" even if user has no permissions to invite #5731

Closed
Anderas opened this issue Mar 2, 2022 · 0 comments · Fixed by #6297
Closed

Room header is showing "Add people" even if user has no permissions to invite #5731

Anderas opened this issue Mar 2, 2022 · 0 comments · Fixed by #6297
Assignees
@ismailgulek
Labels
A-Room-Settings O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-WTF WTF issues: High impact, Low Effort

Comments

@Anderas
Copy link
Contributor

Anderas commented Mar 2, 2022

Steps to reproduce

  1. Invite user A to a new room
  2. Change permissions of the room so that room A cannot invite new users (eg set it to Admin only)
  3. Navigate to the room by user A
  4. Notice that the header still contains "app people" button. SImilar button is correctly hidden on the web

Simulator Screen Shot - iPhone 13 - 2022-03-02 at 13 02 14

Outcome

What did you expect?

The "add people" button should be hidden and user without correct permissions should not be able to invite new users

What happened instead?

User sees the "add people" button

Your phone model

No response

Operating system version

No response

Application version

No response

Homeserver

No response

Will you send logs?

No
@Anderas Anderas added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Mar 2, 2022
@Anderas Anderas added O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Mar 2, 2022
@Anderas Anderas added Z-WTF WTF issues: High impact, Low Effort A-Room-Settings labels Mar 2, 2022
This was referenced Mar 4, 2022
Closed
Merged
@ismailgulek ismailgulek mentioned this issue Jun 14, 2022
Merged
@ismailgulek ismailgulek self-assigned this Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ismailgulek ismailgulek

Labels
A-Room-Settings O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-WTF WTF issues: High impact, Low Effort
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix room header invite button logic element-hq/element-ios
2 participants
@ismailgulek @Anderas