Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace user indicator presenting view controller with context #5780

Closed
Anderas opened this issue Mar 9, 2022 · 0 comments · Fixed by #5781
Closed

Replace user indicator presenting view controller with context #5780

Anderas opened this issue Mar 9, 2022 · 0 comments · Fixed by #5781
Labels
A-Activity-Indicators Unifying the activity indicator style across the app T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@Anderas
Copy link
Contributor

Anderas commented Mar 9, 2022

Your use case

As described in this comment there is a potential issue with user indicators on an iPad, if it changes layout between collapsed and non-collapsed, thus changing the root navigation controller for detail indicators.

The solution to this is not passing a specific view controller to user indicator presenters if it can change at runtime, but rather pass-in an abstraction context that will provide the presenting view controller just when needed and not before

Have you considered any alternatives?

No response

Additional context

No response

@Anderas Anderas added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements A-Activity-Indicators Unifying the activity indicator style across the app labels Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Activity-Indicators Unifying the activity indicator style across the app T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant