Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The share extension is generating crash reports #5805

Closed
pixlwave opened this issue Mar 10, 2022 · 1 comment
Closed

The share extension is generating crash reports #5805

pixlwave opened this issue Mar 10, 2022 · 1 comment
Labels
A-ShareExtension O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@pixlwave
Copy link
Member

Steps to reproduce

  1. Enable analytics and crash reports.
  2. Open the photos app and share an image to any room.
  3. Return to Element

Outcome

What did you expect?

The app to resume normally

What happened instead?

A dialog is shown saying that the app crashed.

Since v1.8.0 the Analytics was enabled in the share extension which has the side effect of now enabling crash logging in there too. Whilst it is desirable in the long run, right now this doesn't work as the extension is intentionally crashed to free up any memory it may be using.

// FIXME: Share extension memory usage increase when launched several times and then crash due to some memory leaks.
// For now, we force the share extension to exit and free memory.
[NSException raise:@"Kill the app extension" format:@"Free memory used by share extension"];

For now we should disable crash logging in the share extension until the memory leaks have been fixed.

Your phone model

No response

Operating system version

iOS 15.3.1

Application version

1.8.5

Homeserver

No response

Will you send logs?

No
@pixlwave pixlwave added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Mar 10, 2022
@pixlwave pixlwave mentioned this issue Mar 10, 2022
Closed
@pixlwave pixlwave added A-ShareExtension O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist labels Mar 10, 2022
@pixlwave pixlwave linked a pull request Mar 10, 2022 that will close this issue
Stop logging crashes in the share extension. #5806
Closed
@pixlwave pixlwave mentioned this issue Mar 18, 2022
Merged
@pixlwave
Copy link
Member Author

Fixed by #5871

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-ShareExtension O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stop logging crashes in the share extension. element-hq/element-ios
1 participant
@pixlwave