Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button "Login" not really visible with german language #5875

Closed
daletman opened this issue Mar 19, 2022 · 2 comments · Fixed by #5892
Closed

Button "Login" not really visible with german language #5875

daletman opened this issue Mar 19, 2022 · 2 comments · Fixed by #5892
Assignees
@Anderas
Labels
A-Login O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Critical Prevents work, causes data loss and/or has no workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems X-Needs-Design May require input from the design team

Comments

@daletman
Copy link

Steps to reproduce

The "Anmelden" button is cramped if the app is used in german and users click in the top right corner on "Registrieren" instead.

IMG_2CF4079C7AEE-1

Outcome

What did you expect?

Normally visible Button

What happened instead?

Cramped Button

Your phone model

all

Operating system version

latest

Application version

1.8.3

Homeserver

No response

Will you send logs?

No
@daletman daletman added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Mar 19, 2022
@stefanceriu stefanceriu added A-Login S-Critical Prevents work, causes data loss and/or has no workaround O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Mar 21, 2022
@Anderas Anderas added the X-Needs-Design May require input from the design team label Mar 21, 2022
@Anderas
Copy link
Contributor

Anderas commented Mar 21, 2022 •
edited
Loading

@amshakal could we have the login button and "forgot password" on separate lines? Even if we fix the German case above (e.g. by decreasing font size), it could still be an issue on smaller devices (iPhone SE) and even longer languages. Here are some extreme examples.

English German Double-length Smallest supported device
Simulator Screen Shot - iPhone 13 - 2022-03-21 at 16 38 36 Simulator Screen Shot - iPhone 13 - 2022-03-21 at 16 38 09 Simulator Screen Shot - iPhone 13 - 2022-03-21 at 16 37 40 Simulator Screen Shot - iPod touch (7th generation) - 2022-03-21 at 16 45 08

@ouchadam
Copy link

for reference, the new ftue sign in page

FTUE SIGN IN
2022-03-22T10:26:51,482234973+00:00

@Anderas Anderas self-assigned this Mar 22, 2022
@Anderas Anderas mentioned this issue Mar 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Anderas Anderas

Labels
A-Login O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Critical Prevents work, causes data loss and/or has no workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems X-Needs-Design May require input from the design team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure the login button is always visible element-hq/element-ios
4 participants
@stefanceriu @ouchadam @Anderas @daletman