Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App crashes when trying to join a room by its address #5883

Closed
frakic opened this issue Mar 21, 2022 · 4 comments · Fixed by #5893, #5947 or #6085
Closed

App crashes when trying to join a room by its address #5883

frakic opened this issue Mar 21, 2022 · 4 comments · Fixed by #5893, #5947 or #6085
Assignees
@Anderas
Labels
A-Room crash O-Occasional Affects or can be seen by some users regularly or most users rarely S-Critical Prevents work, causes data loss and/or has no workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems X-Regression

Comments

@frakic
Copy link

frakic commented Mar 21, 2022

Steps to reproduce

  1. Where are you starting? What can you see?
    -I'm searching for rooms
  2. What do you click?
    -I type in the room address: #NewPublicTestRoom:matrix.org
  3. More steps…
    -I tap on the room

Outcome

What did you expect?

I expected to join the room.

What happened instead?

The app crashed instead.

Video.mp4

Your phone model

iPhone 11 Pro

Operating system version

iOS 15.4

Application version

1.8.7 (20220318170855)

Homeserver

matrix.org

Will you send logs?

Yes
@frakic frakic added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems S-Critical Prevents work, causes data loss and/or has no workaround O-Occasional Affects or can be seen by some users regularly or most users rarely A-Room labels Mar 21, 2022
@Anderas Anderas added the crash label Mar 22, 2022
@Anderas Anderas mentioned this issue Mar 22, 2022
Merged
@Anderas Anderas self-assigned this Mar 22, 2022
@frakic
Copy link
Author

frakic commented Mar 29, 2022

@gileluard I'm still experiencing a crash after upgrading to TF build 1.8.9 (20220328134736)

@frakic frakic reopened this Mar 29, 2022
@pixlwave
Copy link
Member

@frakic #5893 isn't part of 1.8.9. It will be part of 1.8.10.

@Anderas Anderas mentioned this issue Mar 29, 2022
Merged
@Anderas
Copy link
Contributor

Anderas commented Mar 29, 2022

It was indeed fixed in a later version. Looking at the code again however I added another check to make sure we catch other possible nil values #5947

@frakic
Copy link
Author

frakic commented Apr 22, 2022

Found again during a Community testing session.
Steps: tap Search > type #element-ios:matrix.org > tap on the room's address > app crashes.
TF build: 1.8.13 (20220420145423)
Device: iPhone 11 Pro
iOS: 15.4.1

@frakic frakic reopened this Apr 22, 2022
@ismailgulek ismailgulek mentioned this issue Apr 28, 2022
Merged
@github-actions github-actions bot mentioned this issue May 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Anderas Anderas

Labels
A-Room crash O-Occasional Affects or can be seen by some users regularly or most users rarely S-Critical Prevents work, causes data loss and/or has no workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems X-Regression
Projects
None yet
Milestone
No milestone
3 participants
@Anderas @pixlwave @frakic