Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Room preview unexpectedly triggering within the room #5939

Closed
frakic opened this issue Mar 29, 2022 · 1 comment · Fixed by #6255
Closed

Room preview unexpectedly triggering within the room #5939

frakic opened this issue Mar 29, 2022 · 1 comment · Fixed by #6255
Assignees
@gileluard
Labels
A-Room O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-WTF WTF issues: High impact, Low Effort

Comments

@frakic
Copy link

frakic commented Mar 29, 2022

Steps to reproduce

  1. Where are you starting? What can you see?
    -I've created a new room
  2. What do you click?
    -I tap anywhere within the green area (except icons)
  3. More steps…
    -Room preview shows at the bottom of my screen

Overlay

Outcome

What did you expect?

I did not expect that tapping anywhere within the marked area would trigger anything. Only tapping on the room's avatar or "Add people" icon should trigger coresponding actions.

What happened instead?

A room preview without any useful information showed up.

Your phone model

iPhone 11 Pro

Operating system version

iOS 15.4

Application version

1.8.9 (20220328134736)

Homeserver

matrix.org

Will you send logs?

No
@frakic frakic added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Mar 29, 2022
@pixlwave pixlwave added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Uncommon Most users are unlikely to come across this or unexpected workflow Z-WTF WTF issues: High impact, Low Effort A-Room labels Mar 29, 2022
@gileluard
Copy link
Contributor

@amshakal First of the the RoomCreationModal had a bug that prevent to display room creation events.

Image

Once fixed we now understand the purpose of this modal:

Image

The problem is that you can trigger this modal from entire the blue area (see following screenshot). Only green areas navigate the user to a dedicated room settings:

Image

Should we limit this area to the room name?

@gileluard gileluard mentioned this issue Jun 8, 2022
Merged
@gileluard gileluard self-assigned this Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gileluard gileluard

Labels
A-Room O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-WTF WTF issues: High impact, Low Effort
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Room preview unexpectedly triggering within the room element-hq/element-ios
3 participants
@pixlwave @gileluard @frakic