Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Authentication: Use the Identity server specified in the well-known. #6177

Closed
Tracked by #5151
pixlwave opened this issue May 18, 2022 · 0 comments · Fixed by #6246
Closed
Tracked by #5151

Authentication: Use the Identity server specified in the well-known. #6177

pixlwave opened this issue May 18, 2022 · 0 comments · Fixed by #6246
Assignees
@ismailgulek
Labels
A-Authentication T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-FTUE Issue is relevant to the first time use project or experience

Comments

@pixlwave
Copy link
Member

pixlwave commented May 18, 2022 •
edited
Loading

Currently the AuthenticationService makes a well-known lookup and then creates a new client based off of that. At the end of the registration flow, the identity server is unset so we should

  • Add the server to the new client (when it is created) based on the well-known content.
  • Make sure the SessionCreator is copying this value if necessary into the MXSession.
@pixlwave pixlwave mentioned this issue May 18, 2022
Closed
28 tasks
@pixlwave pixlwave changed the title Use the Identity server specified in the well-known otherwise use the default. Authentication: Use the Identity server specified in the well-known otherwise use the default. May 18, 2022
@pixlwave pixlwave changed the title Authentication: Use the Identity server specified in the well-known otherwise use the default. Authentication: Use the Identity server specified in the well-known. May 18, 2022
@pixlwave pixlwave added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-FTUE Issue is relevant to the first time use project or experience A-Authentication labels May 18, 2022
@ismailgulek ismailgulek mentioned this issue Jun 3, 2022
Merged
@ismailgulek ismailgulek self-assigned this Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ismailgulek ismailgulek

Labels
A-Authentication T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-FTUE Issue is relevant to the first time use project or experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FTUE: Use the Identity server specified in the well-known element-hq/element-ios
2 participants
@ismailgulek @pixlwave