Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication: Add tests that cover the service/wizards. #6179

Open
2 tasks
Tracked by #5151
pixlwave opened this issue May 18, 2022 · 0 comments
Open
2 tasks
Tracked by #5151

Authentication: Add tests that cover the service/wizards. #6179

pixlwave opened this issue May 18, 2022 · 0 comments
Labels
A-Authentication T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-FTUE Issue is relevant to the first time use project or experience

Comments

@pixlwave
Copy link
Member

pixlwave commented May 18, 2022

This can be taken in 2 parts:

  • Test registration part of AuthenticationService and RegistrationWizard (ready now).
  • Test login part of AuthenticationService and LoginWizard (pending implementation).

Probably the easiest way to test these would be to make an AuthenticationRestClient/AuthenticationHTTPClient protocols based on the MXRestClient+Async/MXHTTPClient+Async extensions, make mocks of both and allow AuthenticationService to be configured with the type of client it should create.

For reference: Android tests although they're from the view model and use mock service/wizards.

@pixlwave pixlwave changed the title Add tests for the services. Authentication: Add tests that cover the service/wizards. May 18, 2022
@pixlwave pixlwave added T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-FTUE Issue is relevant to the first time use project or experience A-Authentication labels May 18, 2022
@pixlwave pixlwave self-assigned this Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Authentication T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-FTUE Issue is relevant to the first time use project or experience
Projects
None yet
Development

No branches or pull requests

1 participant