Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tapping a link can sometimes crash the app #6241

Closed
pixlwave opened this issue Jun 3, 2022 · 1 comment
Closed

Tapping a link can sometimes crash the app #6241

pixlwave opened this issue Jun 3, 2022 · 1 comment
Labels
A-Timeline O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@pixlwave
Copy link
Member

pixlwave commented Jun 3, 2022 •
edited
Loading

Steps to reproduce

  1. Open any room.
  2. Send the following message.

Have you seen this: https://github.com/vector-im/element-x-ios
Great stuff

  1. Tap the link.

Note: I have bubbles enabled if that is relevant.

Outcome

What did you expect?

The link to open

What happened instead?

  • The first time I send the message it sometimes pops up the warning that the link’s text doesn’t match the destination.
  • Then if I send it again, tapping the new message crashes the app.

Your phone model

iPad Pro

Operating system version

15.5

Application version

1.8.17 TF

Homeserver

No response

Will you send logs?

No
@pixlwave pixlwave added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Jun 3, 2022
@pixlwave
Copy link
Member Author

pixlwave commented Jun 3, 2022

When the link alert does show, it looks like this which I think is missing the original text:

AB9FF0F5-23D7-4857-92D4-4289C59852A8

@pixlwave pixlwave changed the title Tapping a link in an encrypted room can sometimes crash the app Tapping a link can sometimes crash the app Jun 3, 2022
stefanceriu added a commit that referenced this issue Jun 8, 2022
@stefanceriu
Fixes /issues/6241 - Prevent random crashes when tapping links. Avoid…
7245137 
… displaying the confirmation alert for plain text ones.
@stefanceriu stefanceriu added S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Jun 8, 2022
stefanceriu added a commit that referenced this issue Jun 8, 2022
@stefanceriu
Fixes /issues/6241 - Prevent random crashes when tapping links. Avoid…
02d4007 
… displaying the confirmation alert for plain text ones.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Timeline O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stefanceriu @pixlwave