Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance the VectorHostingController to be presented as a bottom sheet #6376

Closed
gileluard opened this issue Jul 5, 2022 · 0 comments · Fixed by #6377
Closed

Enhance the VectorHostingController to be presented as a bottom sheet #6376

gileluard opened this issue Jul 5, 2022 · 0 comments · Fixed by #6377
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@gileluard
Copy link
Contributor

Your use case

What would you like to do?

Enhance the VectorHostingController to support the bottom sheet style

Why would you like to do it?

We need to present some SwiftUI views as bottom sheets

How would you like to achieve it?

By using the UISheetPresentationController made by Apple.

Have you considered any alternatives?

No response

Additional context

No response
@gileluard gileluard added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Jul 5, 2022
@gileluard gileluard changed the title Present any VectorHostingController as a bottom sheet Enhance the VectorHostingController to be presented as a bottom sheet Jul 5, 2022
@gileluard gileluard mentioned this issue Jul 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enhance the VectorHostingController to be presented as a bottom sheet element-hq/element-ios
1 participant
@gileluard