Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert some fonts that were changed in #6275 #6392

Merged
merged 1 commit into from
Jul 8, 2022
Merged

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Jul 8, 2022

I forgot to come back to investigate why the theme fonts weren't working from Objective-C.

@pixlwave pixlwave marked this pull request as ready for review July 8, 2022 11:40
@pixlwave pixlwave requested review from a team and ismailgulek and removed request for a team July 8, 2022 11:40
@sonarcloud
Copy link

sonarcloud bot commented Jul 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

Merging #6392 (a155fab) into develop (611d1a1) will decrease coverage by 0.32%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #6392      +/-   ##
===========================================
- Coverage     6.55%    6.22%   -0.33%     
===========================================
  Files         1451     1451              
  Lines       155597   155594       -3     
  Branches     62512    62505       -7     
===========================================
- Hits         10198     9691     -507     
- Misses      144993   145498     +505     
+ Partials       406      405       -1     
Impacted Files Coverage Δ
...curity/ManageSession/ManageSessionViewController.m 0.00% <0.00%> (ø)
...Modules/Settings/Security/SecurityViewController.m 0.00% <0.00%> (ø)
Riot/Modules/Settings/SettingsViewController.m 0.00% <0.00%> (ø)
Riot/Modules/LaunchLoading/LaunchLoadingView.swift 0.00% <0.00%> (-100.00%) ⬇️
...es/LaunchLoading/LoadingAnimation/Timeline_1.swift 0.00% <0.00%> (-100.00%) ⬇️
...s/LaunchLoading/LoadingAnimation/ElementView.swift 0.00% <0.00%> (-93.03%) ⬇️
Riot/Modules/Application/LegacyAppDelegate.m 13.66% <0.00%> (-1.63%) ⬇️
...ojiPicker/Data/EmojiMart/EmojiItem+EmojiMart.swift 95.34% <0.00%> (+4.04%) ⬆️
...on/NavigationController/RiotNavigationController.m 76.08% <0.00%> (+10.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 611d1a1...a155fab. Read the comment docs.

Copy link
Contributor

@ismailgulek ismailgulek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link

github-actions bot commented Jul 8, 2022

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/jUWfn4

@pixlwave pixlwave merged commit 6340e8f into develop Jul 8, 2022
@pixlwave pixlwave deleted the doug/fonts branch July 8, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants