Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor edge case with new registration page #6489

Closed
aaronraimist opened this issue Jul 28, 2022 · 6 comments · Fixed by #6540
Closed

Minor edge case with new registration page #6489

aaronraimist opened this issue Jul 28, 2022 · 6 comments · Fixed by #6540
Labels
A-Authentication O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-FTUE Issue is relevant to the first time use project or experience

Comments

@aaronraimist
Copy link
Contributor

aaronraimist commented Jul 28, 2022

Great work on the new login and registration pages. Here is a minor edge case I found.

Steps to reproduce

  1. Open the app as a new user
  2. Tap "I already have an account"
  3. Change the homeserver to one that doesn't support registration
  4. Decide that you actually want to register a new account so back out to the initial page
  5. Tap "Create account"
  6. Tap any button for the FTUE use case question

Outcome

What did you expect?

I would be given the opportunity to change the homeserver so that I could register

What happened instead?

I got a dialog box saying registration is not currently supported.

From here there is no obvious next step for a user to take and may think the app is broken. The error message doesn't even say that the homeserver I chose doesn't support registration, it just says "Registration is not currently supported". It would be good to reword this. Element Web uses "Registration has been disabled on this homeserver" which is more clear.

Additionally, instead of throwing up an alert dialog, a better solution would be to integrate the error into the registration page like Element Web does. That way the user can take immediate action to change homeservers rather than having to go back to an entirely different screen.

Your phone model

No response

Operating system version

iOS 15.6

Application version

1.8.24 TestFlight

Homeserver

No response

Will you send logs?

No

@aaronraimist aaronraimist added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Jul 28, 2022
@pixlwave
Copy link
Member

pixlwave commented Jul 28, 2022

Hey, thanks for testing the flow and discovering this. One simple solution to not show any error message we have would be

  • Push to the server selection screen directly and let the user set a server before seeing the registration page (this was previously supported for other reasons so would be a minor change to make).
  • This essentially mirrors the screenshot from Element Web above, but in a more mobile friendly format.

@daniellekirkwood @amshakal WDYT?

@pixlwave pixlwave added the Z-FTUE Issue is relevant to the first time use project or experience label Jul 28, 2022
@daniellekirkwood
Copy link
Contributor

I think it's fine to show this error message - we just need to make sure that the user can get themselves out of this situation easily.

Maybe we show the error on the Create Account screen, not the Use Case screen, so when the user chooses :OK: they can click :EDIT: and change the HS ?

@daniellekirkwood daniellekirkwood added S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Jul 28, 2022
@daniellekirkwood
Copy link
Contributor

We discussed this and decided that we'd drop the remembered HS if the user went back in order to match the Android implementation - is that correct @pixlwave ?

@pixlwave
Copy link
Member

pixlwave commented Aug 2, 2022

Yep correct, we'll revert back to matrix.org. The only exception being if there was a deep-link in which case we'll revert back to that.

@aaronraimist
Copy link
Contributor Author

I'll just note that would not match Element Web behavior. Element Web preserves the server across the sign in and registration pages like iOS does today and personally I think that is a good thing. It avoids the scenario where you changed to your own custom server, then go back and try to register an account and suddenly you have registered on matrix.org rather than the one you explicitly picked unless you look very carefully.

Even if you decide to not preserve the homeserver, if Element iOS is still going to preserve a deep link provided homeserver then this issue could still happen. Therefore I still think moving the error message to a place where the user can act on it would still be prudent.

I realized after I created the issue that better UI for this is already implemented. All you need to do in my opinion is show this page after the FTUE use case question.

image

@aaronraimist
Copy link
Contributor Author

If you wanted, you could add a "reset to default" button there if you want to give users a quick way to get back to matrix.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Authentication O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-FTUE Issue is relevant to the first time use project or experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants