Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display the option "Share invite link" only when the room is accessible by link #6496

Closed
giomfo opened this issue Jul 29, 2022 · 0 comments · Fixed by #6588
Closed

Display the option "Share invite link" only when the room is accessible by link #6496

giomfo opened this issue Jul 29, 2022 · 0 comments · Fixed by #6588
Assignees
Labels
A-Invite O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-PS-Request

Comments

@giomfo
Copy link
Member

giomfo commented Jul 29, 2022

Steps to reproduce

When the user decides to invite new room members, the following screen is displayed:
image
The option "Share invite link" is always displayed

If the user clicks on it, they are invited to send a room link. This link is useful only when the room access is public.

Outcome

I suggest displaying this option only when the room access rule is public (or knock)
I would hide this option for other room access value : invite, restricted.
In case of a restricted room, the link may work but only for people who match the restriction, so I would prefer to hide it

Your phone model

No response

Operating system version

No response

Application version

No response

Homeserver

No response

Will you send logs?

No

@giomfo giomfo added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Jul 29, 2022
@pixlwave pixlwave added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely A-Invite labels Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Invite O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-PS-Request
Projects
None yet
3 participants