Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xcode 14: There's a thread assertion hit when logging in to an account. #6722

Closed
pixlwave opened this issue Sep 14, 2022 · 0 comments · Fixed by #6728
Closed

Xcode 14: There's a thread assertion hit when logging in to an account. #6722

pixlwave opened this issue Sep 14, 2022 · 0 comments · Fixed by #6728
Labels
A-Login os:iOS16 T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@pixlwave
Copy link
Member

Steps to reproduce

  1. Build the project in debug mode with Xcode 14.
  2. Login to an account.

Outcome

What did you expect?

Login to complete

What happened instead?

An assertion is hit:

MatrixSDK/MXUIKitApplicationStateService.swift:70: Assertion failed: [MXUIKitApplicationStateService] initialized on non-main thread.

Seems likely to be a change in behaviour Swift's concurrency with 5.7 given the 2 async functions shown in the stack trace:

Screenshot 2022-09-14 at 8 38 35 pm

Your phone model

iPhone 14 Simulator

Operating system version

iOS 16

Application version

1.9.6 on develop

Homeserver

No response

Will you send logs?

No
@pixlwave pixlwave added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems A-Login os:iOS16 labels Sep 14, 2022
Johennes added a commit that referenced this issue Sep 15, 2022
@Johennes
Fix login crash on Xcode 14 builds
2a9d7c9 
Fixes #6722
@Johennes Johennes mentioned this issue Sep 15, 2022
Merged
8 tasks
ismailgulek added a commit that referenced this issue Sep 20, 2022
@ismailgulek @SBiOSoftWhare
@pixlwave @germain-gg @stefanceriu @paleksandrs @langleyd @aringenbach @Anderas @Johennes @gileluard
Release 1.9.6 (#6747)
fbf78b4 
* Device manager: add user sessions overview current session strings.

* Create UserSessionCardView to display session informations.

* UserSessionsOverview: Handle current session section view.

* Prepare for new sprint

* Dismiss the launching screen when clearing cache.

* Fix crash when previewing a room.

* Fix typo in empty state

* Code review fixes

* Update swift-ogg and add changelog

* Fix crash on logout from too much wrong pin codes

* Update changelog to original issue

* Disable unnecessary network breadcrumbs in Sentry

* Changelog

* Fix login crash on Xcode 14 builds

Fixes #6722

* Put the session creator on the main actor instead.

This covers all login and registration options.

* Only disable the composer if the room is yet to be created.

* Add missing source views for iPad.

* New App Layout: fixed rooms list doesn't update after log out and log into another account

* New layout: Fixed low priority rooms titles obscured by bottom bar when side scrolling

* Fix replied event content parsing for nested replies

* Fixed failed to join room (was not legal room)

* Timeline composer layout loop fix (#6743)

* Publish suitable view height for user suggestions

* Update container view height

* Add changelog

* Fix user suggestions layout for pre iOS 16

* version++

Co-authored-by: SBiOSoftWhare <steveb@matrix.org>
Co-authored-by: Doug <douglase@element.io>
Co-authored-by: Germain Souquet <germain@souquet.com>
Co-authored-by: Stefan Ceriu <stefanc@matrix.org>
Co-authored-by: Aleksandrs Proskurins <paleksandrs@gmail.com>
Co-authored-by: David Langley <langley.dave@gmail.com>
Co-authored-by: aringenbach <arnaudr@element.io>
Co-authored-by: aringenbach <80891108+aringenbach@users.noreply.github.com>
Co-authored-by: Andy Uhnak <andyuhnak@gmail.com>
Co-authored-by: Johannes Marbach <johannesm@element.io>
Co-authored-by: Gil Eluard <gile@element.io>
Co-authored-by: Gil Eluard <gil.eluard@gmail.com>
Co-authored-by: gulekismail <ismailgulek0@gmail.com>
@stefanceriu stefanceriu mentioned this issue Oct 7, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Login os:iOS16 T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix login crash on Xcode 14 builds element-hq/element-ios
1 participant
@pixlwave