Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nested replies have regressed #6729

Closed
ara4n opened this issue Sep 15, 2022 · 1 comment · Fixed by #6745
Closed

Nested replies have regressed #6729

ara4n opened this issue Sep 15, 2022 · 1 comment · Fixed by #6745
Assignees
@aringenbach
Labels
A-Timeline O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@ara4n
Copy link
Member

ara4n commented Sep 15, 2022

Steps to reproduce

If someone replies to a reply, i think we used to only see the most recent reply. Now we see the two most recent replies, but you can’t tell which is which, as there is no indenting or anything.

A131B420-97E4-4CDF-A0BF-2A7320705A37

Outcome

What did you expect?

Only show the most recent reply

What happened instead?

The two modt recent replies got jumbled up

Your phone model

iphone 12 pro max

Operating system version

15.4

Application version

latest tf

Homeserver

m.org

Will you send logs?

No
@ara4n ara4n added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Sep 15, 2022
@pixlwave pixlwave added A-Timeline S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Sep 16, 2022
@Johennes
Copy link
Contributor

Not sure if related but this message doesn't seem to render any replies on current develop.

Simulator Screen Shot - iPhone 14 Pro - 2022-09-19 at 12 24 14

I also have an internal report from a user who claims to not see the message at all on Element iOS 1.9.5.

@aringenbach aringenbach self-assigned this Sep 20, 2022
@aringenbach aringenbach mentioned this issue Sep 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aringenbach aringenbach

Labels
A-Timeline O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix replied event content parsing for nested replies element-hq/element-ios
4 participants
@Johennes @ara4n @pixlwave @aringenbach