Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy up TabBarCoordinator now that AllChatsCoordinator exists. #6853

Closed
pixlwave opened this issue Oct 11, 2022 · 0 comments · Fixed by #6862
Closed

Tidy up TabBarCoordinator now that AllChatsCoordinator exists. #6853

pixlwave opened this issue Oct 11, 2022 · 0 comments · Fixed by #6862
Assignees
@gileluard
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-AppLayout

Comments

@pixlwave
Copy link
Member

There are some unused parts of TabBarCoordinator that can now be removed as we present AllChatsCoordinator instead for the places where those code paths would be called. For example:

We should remove this code now its not needed.
@pixlwave pixlwave added T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-AppLayout labels Oct 11, 2022
@pixlwave pixlwave mentioned this issue Oct 11, 2022
Merged
@gileluard gileluard mentioned this issue Oct 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gileluard gileluard

Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-AppLayout
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tidy up TabBarCoordinator now that AllChatsCoordinator exists. element-hq/element-ios
2 participants
@pixlwave @gileluard