Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tap area being too small on composer #6897

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

langleyd
Copy link
Member

Fixes #6896

@langleyd langleyd requested a review from Velin92 October 17, 2022 13:12
@sonarcloud
Copy link

sonarcloud bot commented Oct 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/gJg4mr

Copy link
Member

@Velin92 Velin92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Base: 11.79% // Head: 54.94% // Increases project coverage by +43.14% 🎉

Coverage data is based on head (01cd42a) compared to base (ff0faf5).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #6897       +/-   ##
============================================
+ Coverage    11.79%   54.94%   +43.14%     
============================================
  Files         1573      420     -1153     
  Lines       156087    16563   -139524     
  Branches     63090     6729    -56361     
============================================
- Hits         18407     9100     -9307     
+ Misses      137059     7255   -129804     
+ Partials       621      208      -413     
Impacted Files Coverage Δ
...tSwiftUI/Modules/Room/Composer/View/Composer.swift 90.78% <100.00%> (+0.06%) ⬆️
...SwiftUI/Modules/Common/Extensions/Collection.swift 0.00% <0.00%> (-100.00%) ⬇️
...odules/Common/Util/ScreenTrackerViewModifier.swift 0.00% <0.00%> (-100.00%) ⬇️
...ice/Mock/MockRoomNotificationSettingsService.swift 0.00% <0.00%> (-100.00%) ⬇️
.../Service/UserSessionsOverviewServiceProtocol.swift 0.00% <0.00%> (-100.00%) ⬇️
.../Modules/UserSessions/Common/UserAgentParser.swift 0.00% <0.00%> (-93.68%) ⬇️
...UI/Modules/Common/Bridging/VectorContentView.swift 0.00% <0.00%> (-92.31%) ⬇️
.../ViewModel/RoomNotificationSettingsViewModel.swift 0.00% <0.00%> (-92.31%) ⬇️
...een/View/OnboardingSplashScreenPageIndicator.swift 0.00% <0.00%> (-90.00%) ⬇️
...SplashScreen/View/OnboardingSplashScreenPage.swift 0.00% <0.00%> (-81.25%) ⬇️
... and 1175 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@langleyd langleyd merged commit 5f6baa7 into develop Oct 17, 2022
@langleyd langleyd deleted the langleyd/6896_focus_taps_inside_border branch October 17, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rich Text Composer: Hit area for focus too small
2 participants