Show target user avatars for collapsed membership changes #4148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit switches to displaying the target user's avatar for collapsed membership changes which addresses the avatar issue reported in element-hq#4102. Depends on: matrix-org/matrix-ios-kit#793 Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
Johennes
force-pushed
the
feature/target-avatars
branch
from
d09adcf
to
a81136e
Compare
daniellekirkwood
approved these changes
Feb 7, 2022
stefanceriu
changed the base branch from
develop
to
johennes/feature/target-avatars
|
Thank you for taking the time to raise this. As it had conflicts with develop I took the liberty of merging it to a separate branch and will handle the rest. |
stefanceriu
pushed a commit
that referenced
this pull request
Feb 7, 2022
This commit switches to displaying the target user's avatar for collapsed membership changes which addresses the avatar issue reported in #4102. Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
|
Thanks both and sorry this hung around in unmergeable state. |
stefanceriu
pushed a commit
that referenced
this pull request
Feb 7, 2022
This commit switches to displaying the target user's avatar for collapsed membership changes which addresses the avatar issue reported in #4102. Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit switches to displaying the target user's avatar for collapsed membership changes which addresses the avatar issue reported in #4102.
This now brings the avatar display on par with the Element web app. Collapsed membership changes use the target avatar, expanded changes use the sender avatar. Note that the web app currently still has more sophisticated logic around combining membership changes (e.g. "... invited and joined") which allows it to show less collapsed avatars in certain cases.
Depends on: matrix-org/matrix-ios-kit#793
Signed-off-by: Johannes Marbach n0-0ne+github@mailbox.org
Pull Request Checklist