Fix memory leak in [RecentsDataSource dataSource:didStateChange:] #4193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The block passed into `[MXSession listenToEventsOfTypes:onEvent:]` is stored with a strong reference in the `listenerBlock` property of `MXSessionEventListener`. The method also returns the listener and it is then stored into the `roomTagsListenerByUserId` dictionary on `self`. Since a strong reference to `self` is captured in the block that means the block retains `self` (via the capture) and `self` retains the block (via `roomTagsListenerByUserId`) so there is a memory leak. The bug is most easily reproduced during testing element-hq#4168 which involves closing the current and creating a new session. Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
Johennes
force-pushed
the
feature/recents-leak
branch
from
3b5fad6
to
978ddd4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The block passed into
[MXSession listenToEventsOfTypes:onEvent:]is stored with a strong reference in thelistenerBlockproperty ofMXSessionEventListener. The method also returns the listener and it is then stored into theroomTagsListenerByUserIddictionary onself. Since a strong reference toselfis captured in the block that means the block retainsself(via the capture) andselfretains the block (viaroomTagsListenerByUserId) so there is a memory leak.The bug is most easily reproduced during testing #4168 which involves closing the current and creating a new session.
Signed-off-by: Johannes Marbach n0-0ne+github@mailbox.org
Pull Request Checklist