Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated available emojis #5517

Merged
merged 3 commits into from
Feb 8, 2022
Merged

Updated available emojis #5517

merged 3 commits into from
Feb 8, 2022

Conversation

stefanceriu
Copy link
Member

@stefanceriu stefanceriu commented Feb 7, 2022

Updated the list of emojis we present in the application with new data from emoji-mart

@github-actions
Copy link

github-actions bot commented Feb 7, 2022

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/tUWTdd

@aringenbach aringenbach self-assigned this Feb 8, 2022
Copy link
Contributor

@aringenbach aringenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got a fail on last EmojiStoreTests test for some reason, any idea / same output for you ?

XCTAssertTrue failed - Search text "2" should find "2️⃣" but only found []

RiotTests/EmojiStoreTests.swift Outdated Show resolved Hide resolved
@stefanceriu
Copy link
Member Author

Failed again with the same intermittent error:

2022-02-08T10:51:05.5223560Z Failing tests:
2022-02-08T10:51:05.5223700Z 	RiotTests:
2022-02-08T10:51:05.5224110Z 		EmojiStoreTests.testFinds2️⃣WhenSearchingFor2()
2022-02-08T10:51:05.5224520Z 		EmojiStoreTests.testFinds2️⃣WhenSearchingFor2()
2022-02-08T10:51:05.5224920Z 		EmojiStoreTests.testFinds2️⃣WhenSearchingFor2()
2022-02-08T10:51:05.5225320Z 		EmojiStoreTests.testFinds2️⃣WhenSearchingForTwo()
2022-02-08T10:51:05.5225720Z 		EmojiStoreTests.testFinds2️⃣WhenSearchingForTwo()
2022-02-08T10:51:05.5226110Z 		EmojiStoreTests.testFinds2️⃣WhenSearchingForTwo()
2022-02-08T10:51:05.5226130Z 
2022-02-08T10:51:05.5226250Z ** TEST FAILED **

Copy link
Contributor

@aringenbach aringenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it's all good 🥳

@stefanceriu stefanceriu merged commit c9d0a4f into develop Feb 8, 2022
@stefanceriu stefanceriu deleted the stefan/update-emojis branch February 8, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants