Started applying navigation bar theme styles to iOS 13 and 14 too. #5715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanceriu
force-pushed
the
stefan/apply-nav-bar-style-iOS-13
branch
from
85f24ac
to
0b2902e
Compare
pixlwave
reviewed
Mar 1, 2022
| func applyStyle(onNavigationBar navigationBar: UINavigationBar, | ||
| withModernScrollEdgesAppearance modernScrollEdgesAppearance: Bool) { | ||
| navigationBar.tintColor = tintColor | ||
|
|
||
| // On iOS 15 use UINavigationBarAppearance to fix visual issues with the scrollEdgeAppearance style. | ||
| if #available(iOS 15.0, *) { | ||
| // On iOS 13+ use UINavigationBarAppearance to fix visual issues with the scrollEdgeAppearance style. |
There was a problem hiding this comment.
Technically this comment is still only referring to iOS 15, as 13 & 14 don't have a scrollEdgeAppearance property.
|
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/DbQfPT |
stefanceriu
force-pushed
the
stefan/apply-nav-bar-style-iOS-13
branch
from
0b2902e
to
442beb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.