Prevent the homescreen from resetting on every appearance. #5885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanceriu
force-pushed
the
stefan/home-screen-reloads
branch
from
f24b81b
to
281915f
Compare
stefanceriu
force-pushed
the
stefan/home-screen-reloads
branch
from
281915f
to
cb97877
Compare
stefanceriu
requested review from
a team and
Anderas
and removed request for
a team
|
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Hcn9qm |
Anderas
approved these changes
Mar 22, 2022
| { | ||
| // Take the lead on the shared data source. | ||
| [recentsDataSource setDelegate:self andRecentsDataSourceMode:RecentsDataSourceModeHome]; | ||
| } | ||
|
|
||
| [self moveAllCollectionsToLeft]; |
There was a problem hiding this comment.
Not sure I understand what the original purpose of calling moveAllCollectionsToLeft was 😕
There was a problem hiding this comment.
I assume at some point in time the homescreen didn't automatically reload everything on appear and this was required to reset your horizontal offsets as a "feature" so you don't lose unread messages or something ¯_(ツ)_/¯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.