Rename completion to callback and simplify actor usage. #6141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixlwave
force-pushed
the
doug/onboarding_callback
branch
from
18c3744
to
ab11544
Compare
pixlwave
requested review from
a team,
phloux,
MaximeEvrard42 and
stefanceriu
and removed request for
a team and
phloux
|
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/YWpv2P |
MaximeEvrard42
approved these changes
May 11, 2022
pixlwave
force-pushed
the
doug/onboarding_callback
branch
from
ab11544
to
f9ffc71
Compare
|
(The force push resolved merge conflicts, nothing changed). |
stefanceriu
approved these changes
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small tidy up following on from #6056 and #6048.
callback.startandprocess(viewAction:)to align with Email/Terms/ReCaptcha screens.