Filtering fixes #6184
Filtering fixes #6184
Conversation
stefanceriu
requested review from
a team,
pixlwave and
phloux
and removed request for
a team
| @@ -114,7 +114,7 @@ - (void)viewWillAppear:(BOOL)animated | |||
| [recentsDataSource setDelegate:self andRecentsDataSourceMode:RecentsDataSourceModeHome]; | |||
|
|
|||
| // Reset filtering on the shared data source when switching tabs | |||
| [self searchBarCancelButtonClicked:self.recentsSearchBar]; | |||
| [recentsDataSource searchWithPatterns:nil]; | |||
There was a problem hiding this comment.
This basically makes it the same as all the other tabs in which it worked properly.
| stackView.axis = .vertical | ||
| stackView.distribution = .fill | ||
| stackView.alignment = .fill | ||
|
|
||
| view.vc_addSubViewMatchingParentSafeArea(stackView) | ||
| view.addSubview(stackView) | ||
| NSLayoutConstraint.activate([stackView.topAnchor.constraint(equalTo: self.view.safeAreaLayoutGuide.topAnchor), |
There was a problem hiding this comment.
Only caring about the top safe area layout guide as that's the place we show the version banner. The bottom one will be handled by the real homeVC.
| @@ -0,0 +1 @@ | |||
| Fixed home screen shrinking too much on opening the keyboard. | |||
There was a problem hiding this comment.
Will this differently named changelog be picked up?
There was a problem hiding this comment.
Yep, it's part of our normal naming scheme - https://github.com/matrix-org/matrix-ios-sdk/blob/develop/CONTRIBUTING.md#changelog -> pr-[PRNumber].type for a PR with no related issue
|
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/wyqwLG |
stefanceriu
force-pushed
the
stefan/filtering-fixes
branch
from
aef60f6
to
e016e75
Compare
Fixes