Support SSO login in the new flow. #6204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixlwave
force-pushed
the
doug/5151_sso_login
branch
from
fde5b1e
to
9abcab9
Compare
|
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/mErdka |
Fix SSO buttons pressed appearance.
pixlwave
requested review from
a team,
SBiOSoftWhare and
ismailgulek
and removed request for
a team
Scale SSO button icon with dynamic type. Add an onCommit parameter to RoundedBorderTextField and use to submit instead of onEditingChanged.
SBiOSoftWhare
approved these changes
May 30, 2022
|
|
||
| return isPressed ? theme.colors.accent.opacity(0.6) : theme.colors.accent | ||
| private func opacity(when isPressed: Bool) -> CGFloat { | ||
| guard isEnabled else { return 0.6 } |
There was a problem hiding this comment.
Optional: We can make a constant for the 0.6 even internal in the method.
There was a problem hiding this comment.
BTW, I didn't ignore this. I'm going to come back to it in the DesignKit PR instead of here :)
ismailgulek
approved these changes
May 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the use of
SSOAuthenticationPresenterto the new flow. AdditionallyAuthenticationServiceinstead of through theLegacyAppDelegate.SFSafariViewControllerwas used where the vc was never dismissed.#unavailablecan be used.onCommitactions to the text fields on the login/registration screens.