Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent the Pin entry screen from being overlapped. #6249

Merged
merged 1 commit into from
Jun 8, 2022

Conversation

stefanceriu
Copy link
Member

This PR moves the Pin entry screen to its own window so it doesn't get overlapped by other views, especially the session verification alert and screens.

@stefanceriu stefanceriu force-pushed the stefan/fullyBlockingPinScreen branch from bc30437 to ffd56de Compare June 7, 2022 12:17
@stefanceriu stefanceriu requested review from a team, Anderas and aringenbach and removed request for a team June 7, 2022 12:18
Copy link
Contributor

@aringenbach aringenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise 👍

@github-actions
Copy link

github-actions bot commented Jun 7, 2022

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Wojshu

@stefanceriu stefanceriu force-pushed the stefan/fullyBlockingPinScreen branch from ffd56de to 3617d07 Compare June 8, 2022 06:02
@stefanceriu stefanceriu merged commit dcebfaf into develop Jun 8, 2022
@stefanceriu stefanceriu deleted the stefan/fullyBlockingPinScreen branch June 8, 2022 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants