Remove render edit flag and fix a nil room state crash #6251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aringenbach
force-pushed
the
aringenbach/remove_edit_mode_flag_fix_roomstate_crash
branch
from
2acc0a4
to
7ce4379
Compare
aringenbach
requested review from
a team,
pixlwave and
gileluard
and removed request for
a team
pixlwave
approved these changes
Jun 7, 2022
Riot/Modules/MatrixKit/Utils/EventFormatter/MXKEventFormatter.m
Outdated
Show resolved
Hide resolved
gileluard
approved these changes
Jun 7, 2022
|
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Ar9whm |
aringenbach
deleted the
aringenbach/remove_edit_mode_flag_fix_roomstate_crash
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the flag for edit mode and uses an empty room state instead for editable text HTML render.
Also, it fixes a crash when room state is empty while trying to render a reply.