-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
De-labs message bubbles #6285
De-labs message bubbles #6285
Conversation
Signed-off-by: Johannes Marbach <johannesm@element.io>
87dd47e
to
0b6123f
Compare
I'm wondering if it would make sense to de-labs Show Latest Avatar as it is done on Android as well. In that case, perhaps my note here would make sense as well: #6272 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Johennes LGTM. 1 question though, were there fixes made prior to this PR to make messages bubbles ready for de-labsing? Or what were we waiting on again? other platforms? product decision?
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/23MuqH |
@aringenbach I suppose this would happen separately from this PR though? CC @jakewb-b. |
@aringenbach Yea it's already decided with product we will de-labs user avatars, there is a issue int he backlog for it if you want to pick up the iOS ticket. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Msg bubbles are nice but de-labbing them feels a bit premature as you still cannot tap the user avatars with bubbles enabled .. which is an essential function if you are a moderator in a room and need to be able to remove/ban people. |
We're moving message bubbles out of labs to match the other platforms.
Requested by @jakewb-b.
Before
After
Pull Request Checklist