Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-labs message bubbles #6285

Merged
merged 1 commit into from
Jun 14, 2022
Merged

De-labs message bubbles #6285

merged 1 commit into from
Jun 14, 2022

Conversation

Johennes
Copy link
Contributor

@Johennes Johennes commented Jun 14, 2022

We're moving message bubbles out of labs to match the other platforms.

Requested by @jakewb-b.

Before

Simulator Screen Shot - iPhone 13 Pro Max - 2022-06-14 at 10 35 13

After

Simulator Screen Shot - iPhone 13 Pro Max - 2022-06-14 at 10 38 19

Pull Request Checklist

  • I read the contributing guide
  • UI change has been tested on both light and dark themes, in portrait and landscape orientations and on iPhone and iPad simulators
  • Accessibility has been taken into account.
  • Pull request is based on the develop branch
  • Pull request contains a changelog file in ./changelog.d
  • You've made a self review of your PR
  • Pull request includes screenshots or videos of UI changes
  • Pull request includes a sign off

@Johennes Johennes marked this pull request as draft June 14, 2022 08:43
Signed-off-by: Johannes Marbach <johannesm@element.io>
@Johennes Johennes marked this pull request as ready for review June 14, 2022 08:46
@Johennes Johennes requested review from a team, SBiOSoftWhare, MaximeEvrard42 and langleyd and removed request for a team and SBiOSoftWhare June 14, 2022 08:46
@aringenbach
Copy link
Contributor

I'm wondering if it would make sense to de-labs Show Latest Avatar as it is done on Android as well.

In that case, perhaps my note here would make sense as well: #6272 (comment)

Copy link
Member

@langleyd langleyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Johennes LGTM. 1 question though, were there fixes made prior to this PR to make messages bubbles ready for de-labsing? Or what were we waiting on again? other platforms? product decision?

@github-actions
Copy link

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/23MuqH

@Johennes
Copy link
Contributor Author

@Johennes LGTM. 1 question though, were there fixes made prior to this PR to make messages bubbles ready for de-labsing? Or what were we waiting on again? other platforms? product decision?

@langleyd no further fixes made, no. Apparently this was just pending a product decision.

@Johennes
Copy link
Contributor Author

I'm wondering if it would make sense to de-labs Show Latest Avatar as it is done on Android as well.

In that case, perhaps my note here would make sense as well: #6272 (comment)

@aringenbach I suppose this would happen separately from this PR though? CC @jakewb-b.

@langleyd
Copy link
Member

@aringenbach Yea it's already decided with product we will de-labs user avatars, there is a issue int he backlog for it if you want to pick up the iOS ticket.

Copy link
Contributor

@MaximeEvrard42 MaximeEvrard42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Johennes Johennes merged commit e44cf56 into develop Jun 14, 2022
@Johennes Johennes deleted the johannes/delabs-bubbles branch June 14, 2022 13:18
@valynor
Copy link

valynor commented Jun 20, 2022

Msg bubbles are nice but de-labbing them feels a bit premature as you still cannot tap the user avatars with bubbles enabled .. which is an essential function if you are a moderator in a room and need to be able to remove/ban people.

@Johennes
Copy link
Contributor Author

Thanks for raising this @valynor. I opened #6322 to try and address the non-tappable avatar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants