Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make quoting context menu action work again #6328

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Make quoting context menu action work again #6328

merged 1 commit into from
Jun 21, 2022

Conversation

Johennes
Copy link
Contributor

This fixes the quoting action from the "more" section of the message context menu. The action previously didn't appear to do anything because the setter of textMessage only handled nil arguments.

I also made a small fix to prevent prepending an empty line when quoting with an empty composer.

Context menu Quoted text
Simulator Screen Shot - iPhone 13 Pro Max - 2022-06-21 at 15 46 43 Simulator Screen Shot - iPhone 13 Pro Max - 2022-06-21 at 15 46 46

Pull Request Checklist

  • I read the contributing guide
  • UI change has been tested on both light and dark themes, in portrait and landscape orientations and on iPhone and iPad simulators
  • Accessibility has been taken into account.
  • Pull request is based on the develop branch
  • Pull request contains a changelog file in ./changelog.d
  • You've made a self review of your PR
  • Pull request includes screenshots or videos of UI changes
  • Pull request includes a sign off

@Johennes Johennes marked this pull request as draft June 21, 2022 13:49
@Johennes
Make quoting work again
fbdd11f 
Signed-off-by: Johannes Marbach <johannesm@element.io>
@Johennes Johennes changed the title Make quoting work again Make quoting context menu action work again Jun 21, 2022
@Johennes Johennes marked this pull request as ready for review June 21, 2022 13:50
@Johennes Johennes requested review from a team, ismailgulek and aringenbach and removed request for a team June 21, 2022 13:50
@sonarcloud
Copy link

sonarcloud bot commented Jun 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

ismailgulek
ismailgulek approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@ismailgulek ismailgulek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, LGTM!

aringenbach
aringenbach approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@aringenbach aringenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Johennes Johennes merged commit 03d37b5 into develop Jun 21, 2022
@Johennes Johennes deleted the johannes/quoting branch June 21, 2022 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ismailgulek ismailgulek ismailgulek approved these changes

@aringenbach aringenbach aringenbach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Johennes @ismailgulek @aringenbach