-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up iOS 14 availability checks #6333
Conversation
…#available(iOS 14... Signed-off-by: Johannes Marbach <johannesm@element.io>
Signed-off-by: Johannes Marbach <johannesm@element.io>
Kudos, SonarCloud Quality Gate passed! |
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/RqMxdv |
Codecov Report
@@ Coverage Diff @@
## develop #6333 +/- ##
=========================================
Coverage 6.17% 6.17%
=========================================
Files 1440 1440
Lines 155408 155099 -309
Branches 62521 62360 -161
=========================================
- Hits 9592 9584 -8
+ Misses 145413 145112 -301
Partials 403 403
Continue to review full report at Codecov.
|
@pixlwave / @ismailgulek I assigned you manually as reviewers because you seem to be around and this week might be a good one to get this large diff landed. 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this Johennes (and for splitting it up into smaller commits 🙏).
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I hope there is not a fork who wants to support pre iOS 14 :)
Now that the minimum deployment target is iOS 14, we can remove a bunch of availability checks. This PR contains two commits.
The first commit removes all
@available(iOS 14...
. This was done with a regex replace.The second commit expands
if
s andguard
s that involved@available(iOS 14...
or#available(iOS 14...
. This one I have done by hand so you probably want to look at it more closely.Note that there are still availability checks pre-iOS14 left. I haven't touched those to note make this PR bigger than it already is.
Pull Request Checklist