Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add formatter build reply HTML unit tests #6380

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

aringenbach
Copy link
Contributor

Add unit tests discussed here: #6372 (review)

@aringenbach aringenbach force-pushed the aringenbach/reply_build_html_tests branch from f14741b to d0362f4 Compare July 5, 2022 16:01
@aringenbach aringenbach requested a review from pixlwave July 5, 2022 16:02
@aringenbach aringenbach force-pushed the aringenbach/reply_build_html_tests branch from d0362f4 to 0cda4f6 Compare July 5, 2022 16:03
@sonarcloud
Copy link

sonarcloud bot commented Jul 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link

github-actions bot commented Jul 5, 2022

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Dfxbo6

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😎

@@ -22,7 +22,7 @@

@import DTCoreText;

@interface MXEventFormatterTests : XCTestCase
@interface MXKEventFormatterTests : XCTestCase
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@aringenbach aringenbach merged commit ecd3fb9 into develop Jul 6, 2022
@aringenbach aringenbach deleted the aringenbach/reply_build_html_tests branch July 6, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants