Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug setting nil soft logout credentials. #6417

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Jul 13, 2022

When selecting "Create account" from the splash screen, the soft logout credentials were set to nil which was causing the login screen to be shown instead of the registration screen. This adds the a check for nil credentials to MXKAuthenticationViewController like the one in AuthenticationViewController.

@pixlwave pixlwave marked this pull request as ready for review July 13, 2022 08:47
Copy link
Contributor

@SBiOSoftWhare SBiOSoftWhare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/3SpVSb

@pixlwave pixlwave merged commit 93114e5 into hotfix/1.8.21 Jul 13, 2022
@pixlwave pixlwave deleted the doug/registration branch July 13, 2022 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants