Track all errors in Sentry #6611
Conversation
| @@ -224,7 +224,7 @@ extension ContactsPickerViewModel: ContactsTableViewControllerDelegate { | |||
| case .success: | |||
| self.coordinatorDelegate?.contactsPickerViewModelDidEndInvite(self) | |||
| case .failure: | |||
| MXLog.error("[ContactsPickerViewModel] Failed to invite \(participantId) due to error; \(response.error ?? "nil")") | |||
| MXLog.error("[ContactsPickerViewModel] Failed to invite participant", context: response.error) | |||
There was a problem hiding this comment.
Deliberately not logging userId
| @@ -44,7 +44,7 @@ extension MarkdownToHTMLRenderer: MarkdownToHTMLRendererProtocol { | |||
| ast.repairLinks() | |||
| return try DownHTMLRenderer.astToHTML(ast, options: options) | |||
| } catch { | |||
| MXLog.error("[MarkdownToHTMLRenderer] renderToHTML failed with string: \(markdown)") | |||
| MXLog.error("[MarkdownToHTMLRenderer] renderToHTML failed") | |||
There was a problem hiding this comment.
Not logging the markdown in case it contains sensitive decrypted data. If we get a lot of events without context, we can add mxlog.debug for rageshakes
|
Kudos, SonarCloud Quality Gate passed!
|
|
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/vWe4zV |
Codecov Report
@@ Coverage Diff @@
## develop #6611 +/- ##
===========================================
- Coverage 6.26% 6.25% -0.02%
===========================================
Files 1460 1460
Lines 154426 154467 +41
Branches 62058 61943 -115
===========================================
- Hits 9671 9655 -16
- Misses 144347 144406 +59
+ Partials 408 406 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Complement to matrix-org/matrix-ios-sdk#1558
MXLogErrorandMXLogFailurein Sentry