Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render the PIN entry screen correctly on landscape #6629

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

stefanceriu
Copy link
Member

This PR fixes the PIN entry screen layout if the app is used in landscape mode. It will still force it to be rendered in portrait as per original code.

Copy link
Contributor

@gileluard gileluard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@github-actions
Copy link

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/kFDdYA

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (hotfix/1.9.0@9a2a854). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             hotfix/1.9.0    #6629   +/-   ##
===============================================
  Coverage                ?    5.92%           
===============================================
  Files                   ?     1474           
  Lines                   ?   154971           
  Branches                ?    62175           
===============================================
  Hits                    ?     9177           
  Misses                  ?   145387           
  Partials                ?      407           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@stefanceriu stefanceriu merged commit 75489d5 into hotfix/1.9.0 Aug 25, 2022
@stefanceriu stefanceriu deleted the stefan/pinEntryLandscapeFix branch August 25, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants