Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New session manager labs flag (PSG-792) #6780

Merged
merged 3 commits into from
Sep 30, 2022

Conversation

ismailgulek
Copy link
Contributor

@ismailgulek ismailgulek commented Sep 29, 2022

Requires matrix-org/matrix-ios-sdk#1588

Adds two labs flag to the settings screen.

Simulator Screen Shot - iPhone 13 Pro Max - 2022-09-29 at 16 35 29

@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Base: 10.15% // Head: 10.21% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (82eb61b) compared to base (46a975b).
Patch coverage: 11.76% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6780      +/-   ##
===========================================
+ Coverage    10.15%   10.21%   +0.06%     
===========================================
  Files         1498     1500       +2     
  Lines       150971   151204     +233     
  Branches     60960    61038      +78     
===========================================
+ Hits         15335    15451     +116     
- Misses      135075   135192     +117     
  Partials       561      561              
Impacted Files Coverage Δ
Config/BuildSettings.swift 43.07% <ø> (ø)
Riot/Modules/Settings/SettingsViewController.m 0.00% <0.00%> (ø)
Config/CommonConfiguration.swift 85.18% <100.00%> (+0.22%) ⬆️
Riot/Managers/Settings/RiotSettings.swift 88.03% <100.00%> (+0.20%) ⬆️
...SplashScreen/OnboardingSplashScreenViewModel.swift 11.53% <0.00%> (-42.31%) ⬇️
...Service/Mock/MockUserSessionsOverviewService.swift 50.00% <0.00%> (-36.96%) ⬇️
...erSessionDetails/UserSessionDetailsViewModel.swift 85.54% <0.00%> (-14.46%) ⬇️
...ing/SplashScreen/View/OnboardingSplashScreen.swift 54.05% <0.00%> (-4.06%) ⬇️
...UserSessions/Common/View/UserSessionCardView.swift 65.15% <0.00%> (-3.11%) ⬇️
...xKit/Controllers/MXKAuthenticationViewController.m 17.04% <0.00%> (-1.92%) ⬇️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Sep 29, 2022

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/JHYasA

@sonarcloud
Copy link

sonarcloud bot commented Sep 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ismailgulek ismailgulek marked this pull request as ready for review September 29, 2022 15:06
@ismailgulek ismailgulek requested review from a team and stefanceriu and removed request for a team September 29, 2022 15:06
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

Copy link
Contributor

@gileluard gileluard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@ismailgulek ismailgulek merged commit 26665fd into develop Sep 30, 2022
@ismailgulek ismailgulek deleted the ismail/device_manager_labs branch September 30, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants