Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include browser version in parsed user agent (PSG-761) #6788

Merged
merged 7 commits into from
Oct 4, 2022

Conversation

ismailgulek
Copy link
Contributor

@ismailgulek ismailgulek commented Oct 3, 2022

Parses browser version and also polishes formatting for macOS:

Simulator Screen Shot - iPhone 13 Pro Max - 2022-10-03 at 14 31 40

@github-actions
Copy link

github-actions bot commented Oct 3, 2022

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/WV6gM3

@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Base: 10.52% // Head: 10.56% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (e0c8ad7) compared to base (26665fd).
Patch coverage: 83.60% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6788      +/-   ##
===========================================
+ Coverage    10.52%   10.56%   +0.04%     
===========================================
  Files         1501     1501              
  Lines       151352   151393      +41     
  Branches     61078    61090      +12     
===========================================
+ Hits         15934    16000      +66     
+ Misses      134849   134824      -25     
  Partials       569      569              
Impacted Files Coverage Δ
.../Modules/UserSessions/Common/UserSessionInfo.swift 100.00% <ø> (ø)
...UserSessions/Common/View/UserSessionCardView.swift 65.18% <0.00%> (-0.49%) ⬇️
...w/Service/MatrixSDK/UserSessionsDataProvider.swift 0.00% <0.00%> (ø)
...erSessionDetails/UserSessionDetailsViewModel.swift 83.14% <50.00%> (-2.40%) ⬇️
.../Modules/UserSessions/Common/UserAgentParser.swift 93.75% <88.23%> (-1.25%) ⬇️
...ionDetails/MockUserSessionDetailsScreenState.swift 100.00% <100.00%> (ø)
...nOverview/MockUserSessionOverviewScreenState.swift 100.00% <100.00%> (ø)
...ervice/MatrixSDK/UserSessionsOverviewService.swift 85.57% <100.00%> (+0.14%) ⬆️
...Service/Mock/MockUserSessionsOverviewService.swift 97.27% <100.00%> (+0.10%) ⬆️
...ot/Modules/Home/AllChats/AllChatsCoordinator.swift 22.15% <0.00%> (+0.11%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ismailgulek ismailgulek marked this pull request as ready for review October 3, 2022 12:58
@ismailgulek ismailgulek requested review from a team and Anderas and removed request for a team October 3, 2022 12:59
@sonarcloud
Copy link

sonarcloud bot commented Oct 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ismailgulek ismailgulek merged commit dadbeca into develop Oct 4, 2022
@ismailgulek ismailgulek deleted the ismail/user_agent_parser_additions branch October 4, 2022 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants