Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing toolbar in AllChatsViewController. #6796

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Oct 4, 2022

The empty artwork view was obscuring it. Changelog added directly to CHANGES.md for the release branch.

Before After
Simulator Screen Shot - iPhone 12 - 2022-10-04 at 14 31 42 Simulator Screen Shot - iPhone 12 - 2022-10-04 at 14 47 14

The empty artwork view was obscuring it.
@pixlwave pixlwave force-pushed the doug/fix-empty-state-toolbar branch from 2f89cc3 to 8438c7f Compare October 4, 2022 13:59
Copy link
Contributor

@gileluard gileluard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 👍

@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Base: 10.60% // Head: 5.99% // Decreases project coverage by -4.60% ⚠️

Coverage data is based on head (8438c7f) compared to base (eda5861).
Patch coverage: 33.33% of modified lines in pull request are covered.

Additional details and impacted files
@@                    Coverage Diff                    @@
##           release/1.9.8/release    #6796      +/-   ##
=========================================================
- Coverage                  10.60%    5.99%   -4.61%     
=========================================================
  Files                       1504     1502       -2     
  Lines                     151609   151588      -21     
  Branches                   61162    61115      -47     
=========================================================
- Hits                       16074     9094    -6980     
- Misses                    134965   142086    +7121     
+ Partials                     570      408     -162     
Impacted Files Coverage Δ
...iot/Modules/Common/Recents/RecentsViewController.m 8.70% <0.00%> (-0.01%) ⬇️
...Modules/Home/AllChats/AllChatsViewController.swift 28.77% <100.00%> (+0.08%) ⬆️
Riot/Categories/Character.swift 0.00% <0.00%> (-100.00%) ⬇️
...otSwiftUI/Modules/Common/Util/BorderModifier.swift 0.00% <0.00%> (-100.00%) ⬇️
...iftUI/Modules/Common/Avatar/Model/Avatarable.swift 0.00% <0.00%> (-100.00%) ⬇️
...iftUI/Modules/Common/Util/RoundedCornerShape.swift 0.00% <0.00%> (-100.00%) ⬇️
...odules/AnalyticsPrompt/AnalyticsPromptModels.swift 0.00% <0.00%> (-100.00%) ⬇️
...odules/Common/DependencyInjection/Injectable.swift 0.00% <0.00%> (-100.00%) ⬇️
...dules/Common/Theme/ThemeUsersColorsExtension.swift 0.00% <0.00%> (-100.00%) ⬇️
...dules/Common/ViewFrameReader/ViewFrameReader.swift 0.00% <0.00%> (-100.00%) ⬇️
... and 253 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Nrt3tL

@pixlwave pixlwave merged commit ec2a176 into release/1.9.8/release Oct 4, 2022
@pixlwave pixlwave deleted the doug/fix-empty-state-toolbar branch October 4, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants