Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rendezvous service (MSC3886) and ECDH X25519 AES 256 based secure… #6806

Merged
merged 3 commits into from
Oct 6, 2022

Conversation

stefanceriu
Copy link
Member

@stefanceriu stefanceriu commented Oct 5, 2022

@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Base: 52.10% // Head: 6.05% // Decreases project coverage by -46.05% ⚠️

Coverage data is based on head (5b2a0cc) compared to base (4eb7a87).
Patch coverage: 46.91% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #6806       +/-   ##
============================================
- Coverage    52.10%    6.05%   -46.06%     
============================================
  Files          377     1513     +1136     
  Lines        14552   152561   +138009     
  Branches      5911    61518    +55607     
============================================
+ Hits          7583     9240     +1657     
- Misses        6786   142913   +136127     
- Partials       183      408      +225     
Impacted Files Coverage Δ
Riot/Modules/Rendezvous/RendezvousTransport.swift 0.00% <0.00%> (ø)
...t/Modules/Rendezvous/MockRendezvousTransport.swift 74.19% <74.19%> (ø)
Riot/Modules/Rendezvous/RendezvousService.swift 77.02% <77.02%> (ø)
Riot/Categories/Character.swift 0.00% <0.00%> (-100.00%) ⬇️
...otSwiftUI/Modules/Common/Util/BorderModifier.swift 0.00% <0.00%> (-100.00%) ⬇️
...iftUI/Modules/Common/Avatar/Model/Avatarable.swift 0.00% <0.00%> (-100.00%) ⬇️
...iftUI/Modules/Common/Util/RoundedCornerShape.swift 0.00% <0.00%> (-100.00%) ⬇️
...odules/AnalyticsPrompt/AnalyticsPromptModels.swift 0.00% <0.00%> (-100.00%) ⬇️
...odules/Common/DependencyInjection/Injectable.swift 0.00% <0.00%> (-100.00%) ⬇️
...dules/Common/Theme/ThemeUsersColorsExtension.swift 0.00% <0.00%> (-100.00%) ⬇️
... and 1414 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Oct 5, 2022

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/AmTpCf

@stefanceriu stefanceriu marked this pull request as ready for review October 6, 2022 13:07
@sonarcloud
Copy link

sonarcloud bot commented Oct 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@ismailgulek ismailgulek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It seems we can inject the RendezvousService into the QRLoginService and update the service state accordingly after some actions. Feel free to replace QRLoginCode with your RendezvousPayload.

Also ftr on matrix-js-sdk it seems the payload updated with an intent: https://github.com/matrix-org/matrix-js-sdk/blob/hughns/http-rendezvous/src/rendezvous/code.ts

RiotTests/RendezvousServiceTests.swift Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants