Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose AuthenticationRestClient async login token generation method (… #6827

Merged
merged 1 commit into from
Oct 10, 2022

Conversation

stefanceriu
Copy link
Member

@stefanceriu stefanceriu commented Oct 7, 2022

…MSC3882)

Needs matrix-org/matrix-ios-sdk#1601

@sonarcloud
Copy link

sonarcloud bot commented Oct 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Oct 7, 2022

Codecov Report

Base: 11.41% // Head: 53.68% // Increases project coverage by +42.26% 🎉

Coverage data is based on head (9b08c89) compared to base (1ee8c9c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #6827       +/-   ##
============================================
+ Coverage    11.41%   53.68%   +42.26%     
============================================
  Files         1544      401     -1143     
  Lines       154237    15603   -138634     
  Branches     62254     6307    -55947     
============================================
- Hits         17606     8376     -9230     
+ Misses      136027     7038   -128989     
+ Partials       604      189      -415     
Impacted Files Coverage Δ
...SwiftUI/Modules/Common/Extensions/Collection.swift 0.00% <0.00%> (-100.00%) ⬇️
.../Modules/UserSessions/Common/UserSessionInfo.swift 0.00% <0.00%> (-100.00%) ⬇️
...odules/Common/Util/ScreenTrackerViewModifier.swift 0.00% <0.00%> (-100.00%) ⬇️
...ice/Mock/MockRoomNotificationSettingsService.swift 0.00% <0.00%> (-100.00%) ⬇️
.../Modules/UserSessions/Common/UserAgentParser.swift 0.00% <0.00%> (-93.75%) ⬇️
...UI/Modules/Common/Bridging/VectorContentView.swift 0.00% <0.00%> (-92.31%) ⬇️
.../ViewModel/RoomNotificationSettingsViewModel.swift 0.00% <0.00%> (-92.31%) ⬇️
...een/View/OnboardingSplashScreenPageIndicator.swift 0.00% <0.00%> (-90.00%) ⬇️
...SplashScreen/View/OnboardingSplashScreenPage.swift 0.00% <0.00%> (-81.25%) ⬇️
Riot/Managers/Theme/ThemeIdentifier.swift 0.00% <0.00%> (-75.00%) ⬇️
... and 1163 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Oct 7, 2022

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/mfPHo5

Copy link
Contributor

@ismailgulek ismailgulek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stefanceriu stefanceriu merged commit 05651f8 into develop Oct 10, 2022
@stefanceriu stefanceriu deleted the stefan/loginTokenGeneration branch October 10, 2022 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants