-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Login with QR code #6857
Login with QR code #6857
Conversation
Codecov ReportBase: 11.56% // Head: 54.04% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #6857 +/- ##
============================================
+ Coverage 11.56% 54.04% +42.48%
============================================
Files 1552 410 -1142
Lines 154678 16160 -138518
Branches 62397 6499 -55898
============================================
- Hits 17884 8734 -9150
+ Misses 136187 7231 -128956
+ Partials 607 195 -412
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/i9fmcH |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some dirty code but I believe we'll handle them later. LGTM!
RiotSwiftUI/Modules/Authentication/QRLogin/Common/Service/QRLoginServiceProtocol.swift
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! |
This PR implements the login with QR code flows when scanning from mobile: