Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login with QR code #6857

Merged
merged 8 commits into from
Oct 12, 2022
Merged

Login with QR code #6857

merged 8 commits into from
Oct 12, 2022

Conversation

stefanceriu
Copy link
Member

This PR implements the login with QR code flows when scanning from mobile:

  • scans a QR code and joins the rendezvous described in it, publishing its public key
  • waits for the initiator's public key and validates it
  • establishes secure channel
  • requests login token and creates a session for with without e2ee support

@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Base: 11.56% // Head: 54.04% // Increases project coverage by +42.48% 🎉

Coverage data is based on head (3586c2a) compared to base (c358f28).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #6857       +/-   ##
============================================
+ Coverage    11.56%   54.04%   +42.48%     
============================================
  Files         1552      410     -1142     
  Lines       154678    16160   -138518     
  Branches     62397     6499    -55898     
============================================
- Hits         17884     8734     -9150     
+ Misses      136187     7231   -128956     
+ Partials       607      195      -412     
Impacted Files Coverage Δ
Config/BuildSettings.swift 0.00% <ø> (-43.08%) ⬇️
...RLogin/Common/Service/QRLoginServiceProtocol.swift 0.00% <ø> (ø)
...Login/Common/Service/Mock/MockQRLoginService.swift 48.83% <100.00%> (-2.28%) ⬇️
...firm/View/AuthenticationQRLoginConfirmScreen.swift 81.60% <100.00%> (ø)
.../MockAuthenticationQRLoginLoadingScreenState.swift 100.00% <100.00%> (ø)
.../Start/View/AuthenticationQRLoginStartScreen.swift 80.00% <100.00%> (ø)
...erSessionsOverview/View/UserSessionsOverview.swift 78.36% <100.00%> (-7.61%) ⬇️
...SwiftUI/Modules/Common/Extensions/Collection.swift 0.00% <0.00%> (-100.00%) ⬇️
...odules/Common/Util/ScreenTrackerViewModifier.swift 0.00% <0.00%> (-100.00%) ⬇️
...ice/Mock/MockRoomNotificationSettingsService.swift 0.00% <0.00%> (-100.00%) ⬇️
... and 1185 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Oct 11, 2022

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/i9fmcH

Copy link
Contributor

@ismailgulek ismailgulek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some dirty code but I believe we'll handle them later. LGTM!

@sonarcloud
Copy link

sonarcloud bot commented Oct 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@stefanceriu stefanceriu merged commit 83c327b into develop Oct 12, 2022
@stefanceriu stefanceriu deleted the stefan/loginWithQRCode branch October 12, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants