Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out application section in session details (PSG-898) #6898

Merged
merged 2 commits into from
Oct 17, 2022

Conversation

alfogrillo
Copy link
Contributor

Ticket -> https://element-io.atlassian.net/browse/PSG-898

Description
This PR hides the "Application" section in the session details when no information are available.

@alfogrillo alfogrillo requested review from a team and stefanceriu and removed request for a team October 17, 2022 14:07
@sonarcloud
Copy link

sonarcloud bot commented Oct 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@github-actions
Copy link

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/FBFB2T

@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Base: 11.79% // Head: 11.79% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (8edd00f) compared to base (ff0faf5).
Patch coverage: 66.66% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6898   +/-   ##
========================================
  Coverage    11.79%   11.79%           
========================================
  Files         1573     1573           
  Lines       156087   156092    +5     
  Branches     63090    63090           
========================================
+ Hits         18407    18414    +7     
+ Misses      137059   137056    -3     
- Partials       621      622    +1     
Impacted Files Coverage Δ
...erSessionDetails/UserSessionDetailsViewModel.swift 85.00% <66.66%> (ø)
...rdinator/ComposerCreateActionListCoordinator.swift 0.00% <0.00%> (ø)
...tSwiftUI/Modules/Room/Composer/View/Composer.swift 90.78% <0.00%> (+0.06%) ⬆️
Riot/Modules/MatrixKit/Models/Account/MXKAccount.m 13.61% <0.00%> (+0.38%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alfogrillo alfogrillo merged commit 8e7a08b into develop Oct 17, 2022
@alfogrillo alfogrillo deleted the alfogrillo/fix_session_details branch October 17, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants