Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unstable prefixes for QR code login #6899

Merged
merged 2 commits into from
Oct 18, 2022

Conversation

hughns
Copy link
Member

@hughns hughns commented Oct 17, 2022

Pull Request Checklist

  • I read the contributing guide
  • UI change has been tested on both light and dark themes, in portrait and landscape orientations and on iPhone and iPad simulators
  • Accessibility has been taken into account.
  • Pull request is based on the develop branch
  • Pull request contains a changelog file in ./changelog.d
  • You've made a self review of your PR
  • Pull request includes screenshots or videos of UI changes
  • Pull request includes a sign off

@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Base: 6.17% // Head: 11.76% // Increases project coverage by +5.59% 🎉

Coverage data is based on head (d0f85ee) compared to base (0340023).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6899      +/-   ##
===========================================
+ Coverage     6.17%   11.76%   +5.59%     
===========================================
  Files         1571     1592      +21     
  Lines       156062   156587     +525     
  Branches     63028    63242     +214     
===========================================
+ Hits          9632    18421    +8789     
+ Misses      146001   137545    -8456     
- Partials       429      621     +192     
Impacted Files Coverage Δ
Riot/Modules/Rendezvous/RendezvousService.swift 76.47% <100.00%> (ø)
Riot/Modules/MatrixKit/Models/Account/MXKAccount.m 13.23% <0.00%> (-0.39%) ⬇️
Riot/Modules/Room/RoomViewController.m 0.00% <0.00%> (ø)
Riot/Modules/Room/RoomCoordinator.swift 0.00% <0.00%> (ø)
Riot/Modules/Settings/SettingsViewController.m 0.00% <0.00%> (ø)
Riot/Modules/Room/CellData/RoomBubbleCellData.m 0.00% <0.00%> (ø)
.../WYSIWYGInputToolbar/WysiwygInputToolbarView.swift 0.00% <0.00%> (ø)
...cast/VoiceBroadcastSDK/VoiceBroadcastService.swift 0.00% <0.00%> (ø)
...Cells/Styles/Plain/PlainRoomTimelineCellProvider.m 0.00% <0.00%> (ø)
...lls/Styles/Bubble/BubbleRoomTimelineCellProvider.m 0.00% <0.00%> (ø)
... and 325 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Oct 17, 2022

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/F8gVYw

@sonarcloud
Copy link

sonarcloud bot commented Oct 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@hughns
Copy link
Member Author

hughns commented Oct 18, 2022

Verified working against latest QR compatible Element Web at https://pr9403--matrix-react-sdk.netlify.app

@stefanceriu
Copy link
Member

Working on my side as well 👍

@stefanceriu stefanceriu merged commit d2d4c06 into develop Oct 18, 2022
@stefanceriu stefanceriu deleted the hughns/unstable-qr-prefixes branch October 18, 2022 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants