Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve external links interaction UX (PSG-819) #6936

Merged
merged 3 commits into from
Oct 20, 2022

Conversation

alfogrillo
Copy link
Contributor

Ticket -> https://element-io.atlassian.net/browse/PSG-819

This PR improves the interaction with external links by:

  • Adding a visual feedback for taps
  • Adding the possibility to see a preview of the web page in the room
mvp2.mp4

@alfogrillo alfogrillo force-pushed the alfogrillo/improve_link_tappability branch from bc892a3 to bda09a1 Compare October 19, 2022 12:49
@sonarcloud
Copy link

sonarcloud bot commented Oct 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@alfogrillo alfogrillo requested review from a team and ismailgulek and removed request for a team October 19, 2022 12:51
Copy link
Contributor

@ismailgulek ismailgulek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, had a tiny question.

@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Base: 6.13% // Head: 11.76% // Increases project coverage by +5.62% 🎉

Coverage data is based on head (bda09a1) compared to base (8987a48).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6936      +/-   ##
===========================================
+ Coverage     6.13%   11.76%   +5.62%     
===========================================
  Files         1590     1592       +2     
  Lines       156596   156630      +34     
  Branches     63187    63256      +69     
===========================================
+ Hits          9608    18420    +8812     
+ Misses      146559   137589    -8970     
- Partials       429      621     +192     
Flag Coverage Δ
uitests 54.86% <ø> (?)
unittests 6.14% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Riot/Modules/Room/RoomViewController.m 0.00% <0.00%> (ø)
.../TimelineCells/Common/MXKRoomBubbleTableViewCell.m 0.29% <0.00%> (-0.01%) ⬇️
Riot/Modules/MatrixKit/Models/Account/MXKAccount.m 13.23% <0.00%> (-0.39%) ⬇️
...SwiftUI/Modules/Common/Locale/LocaleProvider.swift 100.00% <0.00%> (ø)
RiotSwiftUI/RiotSwiftUIApp.swift 95.65% <0.00%> (ø)
...SharingViewer/View/LiveLocationSharingViewer.swift 0.75% <0.00%> (+0.75%) ⬆️
...xKit/Controllers/MXKAuthenticationViewController.m 18.95% <0.00%> (+1.91%) ⬆️
...Modules/Common/Util/PrimaryActionButtonStyle.swift 40.00% <0.00%> (+2.00%) ⬆️
...Modules/Common/ViewModel/StateStoreViewModel.swift 82.60% <0.00%> (+4.34%) ⬆️
...haringViewer/LiveLocationSharingViewerModels.swift 9.09% <0.00%> (+9.09%) ⬆️
... and 296 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alfogrillo alfogrillo merged commit 57ea73a into develop Oct 20, 2022
@alfogrillo alfogrillo deleted the alfogrillo/improve_link_tappability branch October 20, 2022 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants