Deprecate legacy device-to-device verification #6937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anderas
force-pushed
the
andy/trust_devices
branch
from
2a85890
to
ac6c8f0
Compare
Anderas
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
gileluard
requested review from
a team and
phloux
and removed request for
a team
Codecov ReportBase: 11.79% // Head: 11.74% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #6937 +/- ##
===========================================
- Coverage 11.79% 11.74% -0.05%
===========================================
Files 1573 1592 +19
Lines 156087 156624 +537
Branches 63090 63250 +160
===========================================
- Hits 18407 18396 -11
- Misses 137059 137607 +548
Partials 621 621
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Anderas
requested review from
a team and
ismailgulek
and removed request for
phloux and
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding SDK change
Deprecate legacy device-to-device verification that begins with
m.key.verification.startevents rather thanm.key.verification.request. This means that device verification will be observing verification request rather than a transaction