Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add informational sheet for sessions (PSG-714) #6992

Merged
merged 40 commits into from
Nov 9, 2022

Conversation

alfogrillo
Copy link
Contributor

Description

This PR adds informational sheet for the session states in the new device manager

mvp

@alfogrillo alfogrillo requested review from a team, gileluard and janogarcia and removed request for a team October 27, 2022 09:47
@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Base: 11.32% // Head: 11.79% // Increases project coverage by +0.47% 🎉

Coverage data is based on head (794a071) compared to base (c69c3b9).
Patch coverage: 15.09% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6992      +/-   ##
===========================================
+ Coverage    11.32%   11.79%   +0.47%     
===========================================
  Files         1613     1618       +5     
  Lines       158555   158698     +143     
  Branches     64352    64573     +221     
===========================================
+ Hits         17961    18724     +763     
+ Misses      139966   139339     -627     
- Partials       628      635       +7     
Flag Coverage Δ
uitests 54.36% <31.57%> (-0.17%) ⬇️
unittests 6.06% <0.00%> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
RiotSwiftUI/Modules/Common/Extensions/View.swift 0.00% <0.00%> (ø)
...n/InfoSheet/Coordinator/InfoSheetCoordinator.swift 0.00% <0.00%> (ø)
.../Modules/Common/InfoSheet/InfoSheetViewModel.swift 0.00% <0.00%> (ø)
...es/Common/InfoSheet/MockInfoSheetScreenState.swift 0.00% <0.00%> (ø)
...ftUI/Modules/Common/InfoSheet/View/InfoSheet.swift 0.00% <0.00%> (ø)
RiotSwiftUI/Modules/Common/Util/SearchBar.swift 51.06% <0.00%> (ø)
...ions/Coordinator/UserSessionsFlowCoordinator.swift 0.00% <0.00%> (ø)
...ons/Coordinator/UserOtherSessionsCoordinator.swift 0.00% <0.00%> (ø)
...nName/Coordinator/UserSessionNameCoordinator.swift 0.00% <0.00%> (ø)
...ssions/UserSessionName/UserSessionNameModels.swift 100.00% <ø> (ø)
... and 49 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@gileluard gileluard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

# Conflicts:
#	RiotSwiftUI/Modules/UserSessions/Coordinator/UserSessionsFlowCoordinator.swift
#	RiotSwiftUI/Modules/UserSessions/UserOtherSessions/Coordinator/UserOtherSessionsCoordinator.swift
#	RiotSwiftUI/Modules/UserSessions/UserOtherSessions/Test/UI/UserOtherSessionsUITests.swift
#	RiotSwiftUI/Modules/UserSessions/UserOtherSessions/UserOtherSessionsModels.swift
#	RiotSwiftUI/Modules/UserSessions/UserOtherSessions/UserOtherSessionsViewModel.swift
#	RiotSwiftUI/Modules/UserSessions/UserOtherSessions/View/UserOtherSessions.swift
#	RiotSwiftUI/Modules/UserSessions/UserSessionOverview/Test/UI/UserSessionOverviewUITests.swift
# Conflicts:
#	RiotSwiftUI/Modules/UserSessions/UserOtherSessions/UserOtherSessionsModels.swift
#	RiotSwiftUI/Modules/UserSessions/UserOtherSessions/UserOtherSessionsViewModel.swift
#	RiotSwiftUI/Modules/UserSessions/UserSessionOverview/UserSessionOverviewModels.swift
#	RiotSwiftUI/Modules/UserSessions/UserSessionOverview/UserSessionOverviewViewModel.swift
#	RiotSwiftUI/Modules/UserSessions/UserSessionOverview/View/UserSessionOverview.swift
@sonarcloud
Copy link

sonarcloud bot commented Nov 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@alfogrillo alfogrillo merged commit 5b33490 into develop Nov 9, 2022
@alfogrillo alfogrillo deleted the alfogrillo/learn_more_sheet branch November 9, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants