-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve kebab menu in session overview (PSG-832) #7001
Conversation
Kudos, SonarCloud Quality Gate passed! |
Codecov ReportBase: 11.72% // Head: 11.73% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #7001 +/- ##
===========================================
+ Coverage 11.72% 11.73% +0.01%
===========================================
Files 1607 1607
Lines 157869 157882 +13
Branches 63817 63828 +11
===========================================
+ Hits 18504 18535 +31
+ Misses 138735 138717 -18
Partials 630 630
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment inline, otherwise LGTM
} | ||
} label: { | ||
Image(systemName: "ellipsis") | ||
.padding(.horizontal, 4) | ||
.padding(.vertical, 12) | ||
} | ||
.offset(x: 4) // Re-align the symbol after applying padding. | ||
.accessibilityIdentifier("Menu") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps this identifier could be a bit more specific ?
Description
This PR adds the sign out option in the menu in the session overview.