Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve kebab menu in session overview (PSG-832) #7001

Merged
merged 3 commits into from
Nov 2, 2022

Conversation

alfogrillo
Copy link
Contributor

Description

This PR adds the sign out option in the menu in the session overview.

Simulator Screen Shot - iPhone 14 Pro - 2022-10-27 at 17 30 15

@alfogrillo alfogrillo requested review from a team and aringenbach and removed request for a team October 27, 2022 15:32
@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@alfogrillo alfogrillo changed the title Improve kebab menu in session overview (PSG-716) Improve kebab menu in session overview (PSG-832) Oct 27, 2022
@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Base: 11.72% // Head: 11.73% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (0d6c4a1) compared to base (11c388c).
Patch coverage: 61.11% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7001      +/-   ##
===========================================
+ Coverage    11.72%   11.73%   +0.01%     
===========================================
  Files         1607     1607              
  Lines       157869   157882      +13     
  Branches     63817    63828      +11     
===========================================
+ Hits         18504    18535      +31     
+ Misses      138735   138717      -18     
  Partials       630      630              
Flag Coverage Δ
uitests 54.52% <61.11%> (+<0.01%) ⬆️
unittests 6.09% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...UserSessionOverview/View/UserSessionOverview.swift 71.05% <61.11%> (-2.29%) ⬇️
Riot/Modules/MatrixKit/Models/Account/MXKAccount.m 13.15% <0.00%> (-0.39%) ⬇️
...xKit/Controllers/MXKAuthenticationViewController.m 18.95% <0.00%> (+1.91%) ⬆️
...ojiPicker/Data/EmojiMart/EmojiItem+EmojiMart.swift 95.34% <0.00%> (+4.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@aringenbach aringenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment inline, otherwise LGTM

}
} label: {
Image(systemName: "ellipsis")
.padding(.horizontal, 4)
.padding(.vertical, 12)
}
.offset(x: 4) // Re-align the symbol after applying padding.
.accessibilityIdentifier("Menu")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this identifier could be a bit more specific ?

@alfogrillo alfogrillo merged commit 171a8dd into develop Nov 2, 2022
@alfogrillo alfogrillo deleted the alfogrillo/improve_kebab_menu branch November 2, 2022 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants