Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sessions without encryption support (PSG-1003) #7083

Merged
merged 6 commits into from
Nov 18, 2022

Conversation

alfogrillo
Copy link
Contributor

Description
This PR add the support in the new Device Manager to sessions without crypto support.

@alfogrillo alfogrillo requested review from a team and aringenbach and removed request for a team November 16, 2022 11:30
@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Base: 11.74% // Head: 11.74% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (6b01a72) compared to base (62980be).
Patch coverage: 9.16% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7083      +/-   ##
===========================================
- Coverage    11.74%   11.74%   -0.01%     
===========================================
  Files         1620     1620              
  Lines       158933   159162     +229     
  Branches     64621    64731     +110     
===========================================
+ Hits         18666    18687      +21     
- Misses      139630   139839     +209     
+ Partials       637      636       -1     
Flag Coverage Δ
uitests 54.90% <70.83%> (+0.01%) ⬆️
unittests 5.95% <2.91%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Riot/Modules/Room/RoomViewController.m 0.00% <0.00%> (ø)
Riot/Modules/Room/RoomViewController.swift 0.00% <0.00%> (ø)
.../WYSIWYGInputToolbar/WysiwygInputToolbarView.swift 0.00% <0.00%> (ø)
...es/Room/Composer/ViewModel/ComposerViewModel.swift 34.14% <0.00%> (-5.86%) ⬇️
...ions/Coordinator/UserSessionsFlowCoordinator.swift 0.00% <0.00%> (ø)
...tSwiftUI/Modules/Room/Composer/View/Composer.swift 87.91% <100.00%> (+0.41%) ⬆️
.../Modules/UserSessions/Common/UserSessionInfo.swift 95.83% <100.00%> (+0.59%) ⬆️
...serSessions/Common/View/DeviceAvatarViewData.swift 90.00% <100.00%> (ø)
...Sessions/Common/View/UserSessionCardViewData.swift 88.46% <100.00%> (+0.30%) ⬆️
...UserOtherSessions/UserOtherSessionsViewModel.swift 82.51% <100.00%> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@Velin92 Velin92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM two small suggestions

@sonarcloud
Copy link

sonarcloud bot commented Nov 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@alfogrillo alfogrillo merged commit 89fc973 into develop Nov 18, 2022
@alfogrillo alfogrillo deleted the alfogrillo/sessions_without_encryption_support branch November 18, 2022 10:48
@aringenbach aringenbach removed their request for review November 23, 2022 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants