Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scroll issues with VoiceBroadcast and Poll cells #7105

Merged

Conversation

phloux
Copy link
Contributor

@phloux phloux commented Nov 23, 2022

Fix scroll issues with VoiceBroadcastPlayback cells, by fixing SizableBaseRoomCell.

@phloux phloux marked this pull request as ready for review November 23, 2022 14:12
@phloux phloux requested a review from yostyle November 23, 2022 14:13
@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Base: 11.73% // Head: 11.73% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (e1a0db2) compared to base (61073ed).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@                         Coverage Diff                         @@
##           phlpro/voicebroadcast_left_time    #7105      +/-   ##
===================================================================
- Coverage                            11.73%   11.73%   -0.01%     
===================================================================
  Files                                 1620     1620              
  Lines                               159234   159213      -21     
  Branches                             64772    64767       -5     
===================================================================
- Hits                                 18688    18678      -10     
+ Misses                              139910   139898      -12     
- Partials                               636      637       +1     
Flag Coverage Δ
uitests 54.81% <ø> (-0.02%) ⬇️
unittests 5.94% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...imelineCells/SizableCell/SizableBaseRoomCell.swift 0.00% <0.00%> (ø)
...w/Service/MatrixSDK/UserSessionsDataProvider.swift 31.42% <0.00%> (-6.41%) ⬇️
.../Modules/UserSessions/Common/UserSessionInfo.swift 95.23% <0.00%> (-0.60%) ⬇️
...Sessions/Common/View/UserSessionCardViewData.swift 88.15% <0.00%> (-0.31%) ⬇️
...eateActionList/View/ComposerCreateActionList.swift 87.20% <0.00%> (-0.15%) ⬇️
...s/Room/VoiceMessages/VoiceMessageAudioPlayer.swift 0.00% <0.00%> (ø)
.../SwiftUI/VectorHostingBottomSheetPreferences.swift 0.00% <0.00%> (ø)
...nOverview/MockUserSessionOverviewScreenState.swift 100.00% <0.00%> (ø)
...rdinator/ComposerCreateActionListCoordinator.swift 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@yostyle yostyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yostyle yostyle changed the title Fix scroll issues with VoiceBroadcastPlayback cells Fix scroll issues with VoiceBroadcast and Poll cells Nov 23, 2022
Copy link
Contributor

@ismailgulek ismailgulek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@phloux phloux force-pushed the phlpro/voicebroadcast_fix_scroll_issue branch from 85430fc to e1a0db2 Compare November 24, 2022 08:25
@phloux phloux merged commit 7d155c8 into phlpro/voicebroadcast_left_time Nov 24, 2022
@phloux phloux deleted the phlpro/voicebroadcast_fix_scroll_issue branch November 24, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants