-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix scroll issues with VoiceBroadcast and Poll cells #7105
Fix scroll issues with VoiceBroadcast and Poll cells #7105
Conversation
Codecov ReportBase: 11.73% // Head: 11.73% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## phlpro/voicebroadcast_left_time #7105 +/- ##
===================================================================
- Coverage 11.73% 11.73% -0.01%
===================================================================
Files 1620 1620
Lines 159234 159213 -21
Branches 64772 64767 -5
===================================================================
- Hits 18688 18678 -10
+ Misses 139910 139898 -12
- Partials 636 637 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
85430fc
to
e1a0db2
Compare
Fix scroll issues with VoiceBroadcastPlayback cells, by fixing SizableBaseRoomCell.