Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor bottom sheet presentation #7107

Merged
merged 2 commits into from
Nov 23, 2022

Conversation

alfogrillo
Copy link
Contributor

@alfogrillo alfogrillo commented Nov 23, 2022

This PR make easier the code to present a bottom sheet in the device manager using detents.

@sonarcloud
Copy link

sonarcloud bot commented Nov 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@Velin92 Velin92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Base: 11.73% // Head: 11.73% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (af22597) compared to base (8bd53e2).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7107   +/-   ##
========================================
  Coverage    11.73%   11.73%           
========================================
  Files         1620     1620           
  Lines       159239   159193   -46     
  Branches     64781    64755   -26     
========================================
+ Hits         18679    18686    +7     
+ Misses      139924   139871   -53     
  Partials       636      636           
Flag Coverage Δ
uitests 54.88% <ø> (-0.02%) ⬇️
unittests 5.95% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...n/InfoSheet/Coordinator/InfoSheetCoordinator.swift 0.00% <0.00%> (ø)
...nOverview/MockUserSessionOverviewScreenState.swift 100.00% <0.00%> (+2.75%) ⬆️
...es/Room/Composer/ViewModel/ComposerViewModel.swift 29.78% <0.00%> (+2.86%) ⬆️
...Sessions/Common/View/UserSessionCardViewData.swift 88.46% <0.00%> (+6.75%) ⬆️
...tSwiftUI/Modules/Room/Composer/View/Composer.swift 86.09% <0.00%> (+7.66%) ⬆️
...odules/Room/Composer/Model/ComposerViewState.swift 86.95% <0.00%> (+21.57%) ⬆️
.../Modules/UserSessions/Common/UserSessionInfo.swift 95.83% <0.00%> (+26.13%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alfogrillo alfogrillo merged commit c3c5000 into develop Nov 23, 2022
@alfogrillo alfogrillo deleted the alfogrillo/dm_bottom_sheet_refact branch November 23, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants